Skip to content

test(ssh): improve SSH proxy test coverage#1628

Open
fabiovincenzi wants to merge 9 commits into
finos:mainfrom
fabiovincenzi:ssh-test-coverage
Open

test(ssh): improve SSH proxy test coverage#1628
fabiovincenzi wants to merge 9 commits into
finos:mainfrom
fabiovincenzi:ssh-test-coverage

Conversation

@fabiovincenzi

Copy link
Copy Markdown
Contributor

Description

Add tests to improve SSH proxy coverage, focusing on the four modules with the most gaps:

  • server.ts: push flow (no-op detection, security chain integration, pack size/chunk limits, timeout), path validation, auth edge cases, debug mode
  • GitProtocol.ts: happy paths for all 4 exported functions
  • sshInternals.ts: all exported functions with failure modes and error messages
  • AgentForwarding.ts : CHANNEL_OPEN_CONFIRMATION handler, lock recovery

Related Issue

Resolves #1586

Checklist

General

Documentation

  • Documentation has been added/updated for any new features (N/A — test-only changes)

Configuration

  • If configuration schema (config.schema.json) was modified (N/A — no config changes)

Tests

  • Tests have been added/updated for new functionality
  • Unit tests pass (npm test)
  • Linting and formatting pass (npm run lint and npm run format:check)
  • Type checks pass (npm run check-types)

@netlify

netlify Bot commented Jul 1, 2026

Copy link
Copy Markdown

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 56a829d
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6a477e19f8514c00081ec5fe

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (3186da2) to head (56a829d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1628      +/-   ##
==========================================
+ Coverage   85.87%   90.30%   +4.42%     
==========================================
  Files          84       84              
  Lines        8109     8109              
  Branches     1376     1466      +90     
==========================================
+ Hits         6964     7323     +359     
+ Misses       1117      757     -360     
- Partials       28       29       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabiovincenzi fabiovincenzi changed the title Ssh test coverage test(ssh): improve SSH proxy test coverage Jul 1, 2026
@fabiovincenzi fabiovincenzi marked this pull request as ready for review July 3, 2026 09:31
@fabiovincenzi fabiovincenzi requested a review from a team as a code owner July 3, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve SSH Test Coverage

1 participant