fix: misleading endpoint status codes and error messages#1293
Merged
jescalada merged 15 commits intofinos:mainfrom Dec 10, 2025
Merged
fix: misleading endpoint status codes and error messages#1293jescalada merged 15 commits intofinos:mainfrom
jescalada merged 15 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
+ Coverage 80.85% 80.88% +0.02%
==========================================
Files 66 65 -1
Lines 4514 4546 +32
Branches 778 777 -1
==========================================
+ Hits 3650 3677 +27
- Misses 849 854 +5
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I double-checked that the frontend status code handlers are still working. Since we removed a bunch of false 401 errors, most of these would get caught by the generic handler instead. Of course, we should make these more descriptive by showing the actual error message and status code and removing the callback-based error handling entirely. This is captured in #1188 |
40 tasks
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Contributor
Author
|
Thanks for the review @kriswest! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1285. Based on #1202, would love to get that one merged first!