chore(ci): update coverage workflow to use coveralls#110
chore(ci): update coverage workflow to use coveralls#110Orkuncakilkaya wants to merge 10 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s coverage reporting approach by replacing the existing reusable “coverage diff” workflow with an inline workflow that runs tests with coverage and uploads results to Coveralls. It also adds a few Jest specs to increase coverage around the public API surface and SSR/server behavior, and adjusts pnpm workspace configuration.
Changes:
- Replace the reusable coverage-diff workflow with an explicit GitHub Actions job that installs deps, builds, runs
jest --coverage, and uploads to Coveralls. - Add Jest specs validating
public-apiexports, default settings token behavior, and server-platform rejection behavior inFingerprintService. - Update pnpm configuration (workspace allow-build list, add
packageManagerpin) and refresh the lockfile.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/fingerprintjs-pro-angular/src/public-api.spec.ts | Adds a test ensuring public-api exports expected symbols. |
| projects/fingerprintjs-pro-angular/src/lib/tokens/fingerprint-angular-settings-token.spec.ts | Adds a test for the default injection token factory value. |
| projects/fingerprintjs-pro-angular/src/lib/fingerprint.service.server.spec.ts | Adds server-platform tests asserting methods reject when the agent isn’t initialized. |
| projects/fingerprintjs-pro-angular/package.json | Formatting-only change (trailing brace indentation). |
| pnpm-workspace.yaml | Adjusts workspace config and adds allowed build list. |
| pnpm-lock.yaml | Lockfile refresh due to dependency resolution/config changes. |
| package.json | Removes pnpm onlyBuiltDependencies and adds packageManager pin. |
| .github/workflows/coverage-diff.yml | Replaces reusable workflow with inline steps and Coveralls upload. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Orkuncakilkaya
requested review from
JuroUhlar,
TheUnderScorer and
ilfa
as code owners
| packages: | ||
| - 'projects/*' | ||
| - 'projects/*' | ||
| allowBuilds: |
There was a problem hiding this comment.
Are we sure this is a valid config option for the pinned pnpm version (9?)
There was a problem hiding this comment.
You are right, removed with this comment f13658e
JuroUhlar
left a comment
JuroUhlar
left a comment
There was a problem hiding this comment.
left one question, lgtm otherwise!
pnpm exec changesetto create a changeset. |
No description provided.