Feature: Add Open With toolbar flyout#18581
Open
0x5bfa wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an “Open with” toolbar group that dynamically builds a flyout from the Windows shell Open With context menu for the currently selected file.
Changes:
- Introduces
OpenWithMenu(Win32/COM wrapper) to build/enumerate the shell “Open with” menu and invoke selections. - Updates the toolbar to populate an “Open with” flyout asynchronously and adds the group to the default toolbar layout.
- Extends CsWin32 inputs/guids to support
IDataObjectand Open With shell COM usage, plus small config/docs updates.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Files.App/Utils/Shell/OpenWithMenu.cs | New Win32/COM wrapper to construct and invoke the shell “Open with” menu. |
| src/Files.App/UserControls/Toolbar.xaml.cs | Adds async flyout population and binds menu items to OpenWithMenu.InvokeItem. |
| src/Files.App/Properties/launchSettings.json | Renames the launch profile. |
| src/Files.App/Data/Items/ToolbarSections.cs | Adds the “OpenWith” group to default toolbar sections. |
| src/Files.App/Data/Commands/Manager/CommandGroupManager.cs | Defines OpenWithCommandGroup metadata for the toolbar. |
| src/Files.App.CsWin32/NativeMethods.txt | Adds IDataObject to CsWin32 generation inputs. |
| src/Files.App.CsWin32/ManualGuid.cs | Adds GUIDs for IID_IDataObject, CLSID_OpenWithMenu, and BHID_DataObject. |
| CLAUDE.md | Adds a pointer file to agent guidelines. |
| AGENTS.md | Updates repository development guidelines. |
Comments suppressed due to low confidence (1)
CLAUDE.md:1
- As written,
CLAUDE.mdcontains only a bare filename, which isn’t very discoverable for humans/tools that expect markdown guidance. Consider making this an explicit reference (e.g., a short sentence or markdown link) so it’s clear the intent is to redirect toAGENTS.md.
# Files Development Guidelines
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yair100
reviewed
Jun 12, 2026
yair100
reviewed
Jun 12, 2026
yair100
reviewed
Jun 14, 2026
| [AlwaysVisibleContextId] = | ||
| [ | ||
| new(commandGroup: nameof(CommandGroups.NewItem), showLabel: true), | ||
| new(commandCode: ToolbarItemDescriptor.SeparatorCommandCode, showIcon: false), |
Member
There was a problem hiding this comment.
Is there a reason the separator was removed?
Member
|
@0x5bfa I tested the flyout and it works quite well. One issue I noticed is that for files with no supported applications, clicking 'Open with' displays an empty flyout. Are we able to disable the toolbar button for these files? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes