Feature: Extract credentials from FTP URL#18558
Open
xinyuzjj wants to merge 1 commit into
Open
Conversation
yair100
changed the title
hez2010
reviewed
Jun 14, 2026
| public static string GetFtpPath(string path) | ||
| { | ||
| path = path.Replace('\\', '/'); | ||
| path = path.Replace('\', '/'); |
Member
There was a problem hiding this comment.
What's the purpose of this change? I think it won't compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements RFC 1738 compliant FTP URL credential extraction, allowing users to embed credentials directly in the FTP URL (e.g., ) instead of requiring manual dialog input.
Changes
Modified :
Testing
The implementation follows RFC 1738 for FTP URL syntax:
Issue
Closes #14953