Feature: Add Skip and Skip All buttons to File In Use dialog

[codenano077]

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

• Closes Feature: Add skip button when deleting multiple files that are in use by another application #8239

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

1. Opened Files Dev app
2. Locked a file using PowerShell: $file = [System.IO.File]::Open("D:\testlock.txt", "OpenOrCreate", "ReadWrite", "None")
3. Navigated to the locked file in Files Dev
4. Attempted to delete the locked file
5. Confirmed that Retry, Skip, and Skip All buttons appear correctly in the File In Use dialog
6. Clicked Skip to verify it skips the current file
7. Clicked Skip All to verify it skips all locked files

[yair100]

Can you please share screenshot? Also, can you confirm if the skip option only shows when deleting multiple items?

[codenano077]

Here's a screenshot of the dialog with the new buttons:

Regarding your question — the Skip and Skip All buttons currently show for both single and multiple file deletions. However, I think it makes more sense to only show Skip and Skip All when deleting multiple files, since skipping a single locked file is essentially the same as cancelling. Would you like me to update the behavior so Skip only appears when multiple files are being deleted?

[yair100]

Would you like me to update the behavior so Skip only appears when multiple files are being deleted?

Yes, that would be great.

[Josh65-2201]

I'm not certain why there is Skip and Skip all since all files are attempted at the same time so both buttons do the same thing.

Permanently deletes file in use prompt also only has Try again or Cancel buttons like 4.1.3, shouldn't it have the same?

[codenano077]

Thanks for the feedback!

Regarding Skip vs Skip All — you raise a valid point. Could you clarify the intended behavior? Should Skip dismiss the dialog for the current file only and show it again for the next locked file, while Skip All dismisses it for all locked files at once?

Regarding the permanent delete dialog — I can update that to be consistent with this change if that's the desired behavior.

[Josh65-2201]

I think this was fixed while ago but the issue wasn't closed. All in use files are grouped together to show them and what's using it. Unless Yair wants to ungroup them so one file is shown at a time?

[yair100]

I think this was fixed while ago but the issue wasn't closed. All in use files are grouped together to show them and what's using it. Unless Yair wants to ungroup them so one file is shown at a time?

@Josh65-2201 in the latest stable build, what happens with the non-conflicting files, do they finish transferring? I thought that we needed to add a skip button to continue with the non-conflicting items.

[Josh65-2201]

None blocking ones are completed for me

[codenano077]

I tested this as well — non-locked files complete automatically while the dialog shows for locked ones.
Given that all locked files are shown together in one dialog, I agree that Skip All doesn't add much value. I'd suggest simplifying to just a single Skip button that dismisses the dialog and skips all the locked files shown. This keeps it simple and consistent.
Should I update the PR to remove Skip All and keep only Skip?

[Josh65-2201]

Sure, all that's need is changing the Cancel button text to Skip