Skip to content

Conversation

@DarkLord017
Copy link

Related Issues

Fixes #13246

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Oct 18, 2025
@DarkLord017
Copy link
Author

@wjmelements is there any way to test this , like instead of running it e2e

@BigLep BigLep moved this from 📌 Triage to 🔎 Awaiting Review in FilOz Oct 21, 2025
@BigLep BigLep marked this pull request as ready for review October 21, 2025 05:00
Copilot AI review requested due to automatic review settings October 21, 2025 05:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new --order-by-nonce flag to the state list-msgs CLI command, enabling users to retrieve messages ordered sequentially by nonce when filtering by a 'from' address. This addresses issue #13246 by providing a way to view messages in the order they were intended to be executed.

Key changes:

  • Added --order-by-nonce boolean flag with appropriate usage documentation
  • Implemented message buffering and sorting logic that orders messages by nonce when the flag is enabled
  • The ordering only applies when a 'from' address filter is specified

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DarkLord017 DarkLord017 requested a review from Copilot October 21, 2025 08:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@DarkLord017 DarkLord017 requested a review from rvagg October 24, 2025 18:41
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this defaults to no ordering, but we then get the deduped per-tipset message ordering which I think is the correct default

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Jan 8, 2026
@rvagg
Copy link
Member

rvagg commented Jan 8, 2026

@DarkLord017 would you updating from master (merge from master or rebase on master) and then editing the CHANGELOG.md to note the addition of this flag. Look at other changelog entries for the pattern and make sure to reference this PR.

@rvagg
Copy link
Member

rvagg commented Jan 8, 2026

oh, and make gen needs to be run too, when we edit the CLI tools we need to edit the docs that describe how to use them and they come out of the code

@DarkLord017
Copy link
Author

ya sure ! doing that

@DarkLord017
Copy link
Author

done @rvagg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✔️ Approved by reviewer

Development

Successfully merging this pull request may close these issues.

list-messages order should be sequential

2 participants