-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: add ordering by nonce flag to get sequential messages #13394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add ordering by nonce flag to get sequential messages #13394
Conversation
|
@wjmelements is there any way to test this , like instead of running it e2e |
5d90341 to
52ac86d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new --order-by-nonce flag to the state list-msgs CLI command, enabling users to retrieve messages ordered sequentially by nonce when filtering by a 'from' address. This addresses issue #13246 by providing a way to view messages in the order they were intended to be executed.
Key changes:
- Added
--order-by-nonceboolean flag with appropriate usage documentation - Implemented message buffering and sorting logic that orders messages by nonce when the flag is enabled
- The ordering only applies when a 'from' address filter is specified
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rvagg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this defaults to no ordering, but we then get the deduped per-tipset message ordering which I think is the correct default
|
@DarkLord017 would you updating from master (merge from master or rebase on master) and then editing the CHANGELOG.md to note the addition of this flag. Look at other changelog entries for the pattern and make sure to reference this PR. |
|
oh, and |
|
ya sure ! doing that |
|
done @rvagg |
Related Issues
Fixes #13246
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: