fix(pdp): detect contract reverts and exclude terminated datasets from scheduling #869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop infinite retry loop when datasets are terminated on-chain. Detects termination errors at gas estimation, marks datasets terminated, and excludes them from scheduling. Unknown contract reverts get exponential backoff.
Reverting
If an SP wants to try running this code and decides to back out, there is a database migration in here. A revert is possible but you should run:
The old code ignores the new columns, so in theory it will run fine without a DB migration rollback. But you probably should clean up your db schema to be on the safe side for future updates.