Fix Archive::Extract zip member compatibility#785
Merged
Conversation
Expose the CPAN Archive::Zip member hash field used directly by Archive::Extract and accept member objects in extractMember. Update the CPANPLUS progress note with the Archive::Extract result and the next blocker in Object::Accessor. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
Fix the remaining CPANPLUS blockers after Archive::Extract by handling tied lexical scalar cleanup, strict bareword coderef arrow calls, version numification, and stale blib/lib sources in PerlOnJava MakeMaker reruns. Add focused regressions and update the CPANPLUS progress note with the passing test result and follow-up warning. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
fglock
force-pushed
the
fix/cpanplus-archive-extract
branch
from
b7bea84 to
aea3c6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Archive::Zipcompatible with CPANArchive::Extractby exposingfileNameand accepting member objects inextractMember.Object::Accessor, strict bareword coderef arrow parsing forBUILD_PL->(...)/MAKEFILE->(...),versiondotted-vs-decimal numification, and MakeMaker reruns with staleblib/libsources.dev/modules/cpanplus.mdwith the passing CPANPLUS result and next steps.Verification
makepassed.Archive::Extract0.88 upstream suite passed:Files=1, Tests=1795, Result: PASS.Object::Accessorupstream suite passed:Files=7, Tests=155, Result: PASS../jcpan -t CPANPLUSpassed for CPANPLUS 0.9916:Files=20, Tests=1751, Result: PASS.Follow-up
File::Copy.pm line 303warning during its own suite; it does not fail the run.