Fix parser tests #144
Merged
Fix parser tests #144
+76
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix test 44: Handle invalid filetest operators properly
- Check if function exists when encountering -F
- Return -42 for sub F { 42 } -F 1
- Give syntax error for my = -F 1
- Fix test 47: use without body should give syntax error
- Check for valid module name token after use
- Throw syntax error instead of null module error
- Fix tests 48, 49, 50: readline/__FILE__ as prototype
- Detect invalid prototype constructs without parentheses
- Give Illegal declaration error for sub _ <> {}
- Give Illegal declaration error for sub <> {}
- Give Illegal declaration error for sub _ __FILE__ {}
All tests now pass: 43, 44, 45, 47, 48, 49, 50
- Add check for missing closing brace in sub definitions - When ParseBlock.parseBlock reaches EOF without finding }, give 'Missing right curly' error - Instead of 'Expected token OPERATOR with text } but got EOF' - Tests 55 and 56 now pass
- Allow package names like 'o::' which end with :: - This is valid Perl syntax for blessing into packages - Fixes op/sprintf2.t which was failing with 'Bad name after o::::' - Parser tests 51, 52 still pass
- Add ) to allowed tokens after :: in parseSubroutineIdentifier - This allows package names like 'o::' to be used in function calls like bless([], o::) - Fixes op/lexsub.t which was failing with 'Bad name after o::'
- Fix filetest operator detection to handle -a correctly in strict mode - Check what comes after the identifier (skipping whitespace) to decide context - If -X is followed by an operand, treat as invalid filetest operator (error) - If -X is not followed by an operand, treat as string negation (e.g., -a -> '-a') - This fixes test 48 in op/negate.t while preserving test 44 in comp/parser.t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.