Fix stash entry stringification and ref() behavior #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix HashSpecialVariable.getStash() to get existing stash from global hashes instead of creating new one - Add proper logic in RuntimeStash.get() to check if variable exists in global namespace - Add toString() method to RuntimeStashEntry for proper stringification - Add special case for RuntimeStashEntry in ReferenceOperators.ref() to return empty string - All ref.t tests now pass (27/27) This fixes the regression where stash entries were not being properly stringified and ref() was returning incorrect types for stash entries.
- Restore toString() method in RuntimeStashEntry for proper stringification - Restore slot existence checking in RuntimeStash.get() to detect defined variables - Restore RuntimeStashEntry special case in ref() to return empty string Fixes broken make build caused by failing unit/ref.t test
- Windows build: SUCCESS - Ubuntu build: SUCCESS - Both jobs properly run unit tests via gradlew build and maven test - No changes needed to CI/CD configuration
This reverts commit d7e9667.
- The test now has 8 assertions instead of 6 - This matches the actual number of tests being run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken make build caused by failing unit/ref.t test
Changes
Issue
The last commit broke the build by removing critical functionality for stash entry handling, causing unit/ref.t test 27 to fail with "got: undef, expected: '*Testing2::a'" and test 25 to fail with "got: 'SCALAR', expected: ''".
Verification