Fix chat agent: improve prompt, strip DSML leaks#141
Closed
ohld wants to merge 1 commit intoproductionfrom
Closed
Conversation
- Rewrite system prompt: less rule-heavy, more natural persona voice, explicit anti-assistant-cringe guidance, "meme speaks for itself" rule - Add _clean_response() to strip DSML XML artifacts that DeepSeek sometimes outputs as text instead of using tool_calls API - Lower temperature 0.8→0.7 and max_tokens 500→300 for shorter replies - Reduce MAX_TURNS 8→5 (agent shouldn't need 8 rounds) - Improve tool descriptions with usage hints
4 tasks
Member
Author
|
Superseded by #142 which migrates to OpenAI Agents SDK. All fixes from this PR (DSML cleanup, prompt rewrite, parameter tuning, tool descriptions) are included in the SDK migration with a cleaner architecture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<|DSML|function_calls>...) как текст вместо использования tool_calls API. Добавлен_clean_response()с regex, который стрипает эти артефакты перед отправкой в чатЧто было не так
Changes
prompts.pyrunner.py_clean_response()+ regex для DSML, tuning параметровtools.pyTest plan
<|DSML|...>(unit test или manual)