Skip to content

Conversation

@codgician
Copy link

Attempt to address #69

Added optional [@]? pattern in getPropertyRegex() of RegExHelper and added some tests. Not sure if I did this right, please review.

@pull-dog
Copy link

pull-dog bot commented Sep 22, 2020

*Ruff* 🐶 I wasn't able to find any Docker Compose files in your repository at any of the given paths in the pull-dog.json configuration file, or the default docker-compose.yml file 😩 Make sure the given paths are correct.

Files checked:

  • docker-compose.yml
What is this?

Pull Dog is a GitHub app that makes test environments for your pull requests using Docker, from a docker-compose.yml file you specify. It takes 19 seconds to set up (we counted!) and there's a free plan available.

Visit our website to learn more.

Commands
  • @pull-dog up to reprovision or provision the server.
  • @pull-dog down to delete the provisioned server.
Troubleshooting

Need help? Don't hesitate to file an issue in our repository

Configuration

{"isLazy":false,"dockerComposeYmlFilePaths":["docker-compose.yml"],"expiry":"00:00:00","conversationMode":"singleComment"}

Trace ID
cfbf9080-fc76-11ea-99e1-30306186294f

result += this.getAttributesRegex(captureAttributes);
result += this.getModifiersRegex(captureModifiers);
result += this.getGenericTypeNameRegex(captureReturnType, false, false, false, false);
result += "[@]?";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be added as part of the getGenericTypeNameRegex method. Also, I don't think the square brackets are needed? 🤔😊

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be added as part of the getGenericTypeNameRegex method. Also, I don't think the square brackets are needed? 🤔😊

Does that mean '@' should be considered as a part of typename instead of property name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants