chore(deps): bump vite-plus to 0.1.21-alpha.6#3
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus dependency to version 0.1.21-alpha.6 in both the root and apps/docs package files. Feedback indicates that the changes are incomplete based on the pull request description, which also mentioned updates for vite, vitest, and the overrides section. It is recommended to update these related dependencies to their corresponding versions to maintain consistency and prevent potential compatibility issues.
| "typescript": "^6.0.3", | ||
| "vite": "^8.0.10", | ||
| "vite-plus": "^0.1.20", | ||
| "vite-plus": "0.1.21-alpha.6", |
There was a problem hiding this comment.
The PR description states that vite, vitest, and the overrides section were updated where applicable. However, in this file, only vite-plus has been modified. Since vite (line 130), vitest (line 132), and an overrides block (line 135) are present and directly related to the vite-plus ecosystem, they should likely be updated to their corresponding alpha versions to ensure compatibility and fulfill the PR's stated intent.
| "vite": "^8.0.10", | ||
| "vite-plugin-killer-instincts": "^1.1.0", | ||
| "vite-plus": "^0.1.20", | ||
| "vite-plus": "0.1.21-alpha.6", |
There was a problem hiding this comment.
Similar to the root package.json, the dependencies for vite (line 53) and vitest (line 56) remain unchanged here despite the PR description indicating they would be updated. To maintain consistency across the workspace and avoid potential version mismatches with the new vite-plus alpha, these should be updated to their respective versions as part of this dependency bump.
Add vite-plus and @voidzero-dev/vite-plus-* to bun's minimumReleaseAgeExcludes so the alpha can be installed while the global 24h min-age policy stays on.
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.6.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsTest plan