chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#5
Draft
fengmk2 wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the vite-stack dependencies in pnpm-workspace.yaml and package.json to use specific build URLs from pkg.pr.new. It also introduces release age configurations. Feedback indicates that the minimumReleaseAge and minimumReleaseAgeExclude settings are misplaced in pnpm-workspace.yaml and use incorrect casing; these should be moved to an .npmrc file using kebab-case to ensure they are properly recognized by the package manager.
Comment on lines
+120
to
+123
| minimumReleaseAge: 4320 | ||
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
The minimumReleaseAge and minimumReleaseAgeExclude keys are not standard top-level fields for pnpm-workspace.yaml. According to the pnpm documentation, workspace-wide configurations like minimum-release-age should be defined in an .npmrc file. Additionally, the standard pnpm setting uses kebab-case (minimum-release-age and minimum-release-age-exclude). As currently implemented, these settings will likely be ignored by pnpm, npm, and bun.
@vizejs/fresco
@vizejs/musea-mcp-server
@vizejs/musea-nuxt
@vizejs/nuxt
oxlint-plugin-vize
@vizejs/rspack-plugin
@vizejs/unplugin
@vizejs/vite-plugin-musea
@vizejs/vite-plugin
vize
commit: |
PR BenchmarkBase:
Raw run timesCompile SFC
Lint
Type check
|
Detailed Test ReportCommit: Area Summary
Test InventoryTotal tracked cases: 4493 across 608 files.
Files
Full per-test names are written to the workflow summary and uploaded as an artifact. Job Overview
Step DetailsJS / TS / check-js: success, 53s
Rust / fmt-rust: success, 20s
Rust / coverage: success, 1m 0s
Rust / clippy-and-test: success, 3m 48s
E2E / VRT / playground-test: success, 6m 13s
Other / test-scripts: success, 4m 44s
Other / editor-extensions: success, 1m 17s
Other / node-engine-compat (24): success, 27s
Other / check-vize-apps: success, 1m 23s
Other / security-audit: failure, 29s
Other / cargo-semver-checks: success, 9m 0s
Other / node-engine-compat (22): success, 35s
Other / vue-parity: success, 2m 42s| # | Step | Result | Duration | Started | Completed | Comment truncated at 64000 characters. Open the workflow run for the full job log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
vite-plusand related@voidzero-dev/*packages to the pkg-pr-new prerelease for vite-plus PR #1633.Updated where applicable:
vite-plus→https://pkg.pr.new/voidzero-dev/vite-plus@1633vitealias →@voidzero-dev/vite-plus-corepkg-pr-new URLvitestalias →@voidzero-dev/vite-plus-testpkg-pr-new URLoverrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsAlso configured
minimum-release-agewith vite-plus /@voidzero-dev/*excluded for pnpm / bun / npm.Test plan