chore(deps): bump vite-plus to 0.1.21-alpha.7#4
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus stack to version 0.1.21-alpha.7 across the workspace and introduces a minimumReleaseAgeExclude configuration. The reviewer suggests using the vite-stack catalog reference in package.json to ensure version consistency and points out that minimumReleaseAgeExclude is not a standard top-level field for pnpm-workspace.yaml, suggesting it be moved to a more appropriate configuration file.
| "@vscode/vsce": "3.9.1", | ||
| "typescript": "6.0.3", | ||
| "vite-plus": "0.1.19" | ||
| "vite-plus": "0.1.21-alpha.7" |
There was a problem hiding this comment.
Since vite-plus is already defined in the vite-stack catalog within pnpm-workspace.yaml, it is recommended to use the catalog reference here instead of a hardcoded version. This ensures that the version is managed in a single place across the entire workspace, maintaining consistency and simplifying future updates.
| "vite-plus": "0.1.21-alpha.7" | |
| "vite-plus": "catalog:vite-stack" |
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
The minimumReleaseAgeExclude field is not a standard top-level configuration for pnpm-workspace.yaml in pnpm. For pnpm, this setting should typically be defined in .npmrc as minimum-release-age-exclude or in the root package.json under the pnpm key. If this configuration is intended for Bun, please note that Bun expects this setting in bunfig.toml rather than the pnpm workspace file.
PR BenchmarkBase:
Raw run timesCompile SFC
Lint
Type check
|
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan