chore: upgrade vite-plus to 0.1.18-alpha.0#6
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the AGENTS.md documentation to clarify the usage of Vite+ built-in commands and adds a CI integration section, while also updating package versions in pnpm-workspace.yaml. Feedback suggests restoring the recommendation for vp check as a comprehensive validation tool and addresses a potential inconsistency regarding the oxlint-tsgolint configuration in the workspace.
| - **Use Vite+ wrappers for one-off binaries:** Use `vp dlx` instead of package-manager-specific `dlx`/`npx` commands. | ||
| - **Import JavaScript modules from `vite-plus`:** Instead of importing from `vite` or `vitest`, all modules should be imported from the project's `vite-plus` dependency. For example, `import { defineConfig } from 'vite-plus';` or `import { expect, test, vi } from 'vite-plus/test';`. You must not install `vitest` to import test utilities. | ||
| - **Static checks:** Prefer `vp check` as the default validation command. It runs formatting, linting, and type checks together, and `vp lint --type-aware` works when you need lint-only feedback. | ||
| - **Type-Aware Linting:** There is no need to install `oxlint-tsgolint`, `vp lint --type-aware` works out of the box. |
There was a problem hiding this comment.
The recommendation to prefer vp check as the default validation command was removed in this change. This command is valuable because it combines formatting, linting, and type checks into a single step, which is a best practice for agents to follow before submitting changes. Consider merging the new information about oxlint-tsgolint into the existing 'Static checks' section to preserve this guidance.
| - **Type-Aware Linting:** There is no need to install `oxlint-tsgolint`, `vp lint --type-aware` works out of the box. | |
| - **Static checks:** Prefer `vp check` as the default validation command. It runs formatting, linting, and type checks together. For type-aware linting, `vp lint --type-aware` works out of the box; there is no need to install `oxlint-tsgolint`. |
| - oxlint-tsgolint | ||
| - "@oxlint-tsgolint/*" |
There was a problem hiding this comment.
There is a potential inconsistency between the documentation in AGENTS.md (which states oxlint-tsgolint does not need to be installed) and its inclusion in the minimumReleaseAgeExclude list. If oxlint-tsgolint is not a direct dependency of any package in the workspace, it should be removed from this list to keep the configuration clean. If it is still required as a dependency, consider if it can be removed to align with the updated guidelines in AGENTS.md.
1 participant
Upgrade vite-plus and related packages to 0.1.18-alpha.0 alpha version.