Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#14

Draft
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-pr-1633
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#14
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-pr-1633

Conversation

@fengmk2
Copy link
Copy Markdown
Owner

@fengmk2 fengmk2 commented May 19, 2026

Summary

Bump vite-plus and related @voidzero-dev/* packages to the pkg-pr-new prerelease for vite-plus PR #1633.

Updated where applicable:

  • vite-plushttps://pkg.pr.new/voidzero-dev/vite-plus@1633
  • vite alias → @voidzero-dev/vite-plus-core pkg-pr-new URL
  • vitest alias → @voidzero-dev/vite-plus-test pkg-pr-new URL
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs

Also configured minimum-release-age with vite-plus / @voidzero-dev/* excluded for pnpm / bun / npm.

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 19, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pnpm-workspace.yaml configuration by increasing the global minimumReleaseAge for dependencies and introducing an exclusion list for vite-plus and @voidzero-dev/* packages. It also switches the vite, vite-plus, and vitest dependencies to use specific preview build URLs. Feedback suggests that the global increase of the release age to 72 hours may be unnecessary and could block legitimate updates, especially since the specific packages requiring immediate updates are already covered by the new exclusion list.

Comment thread pnpm-workspace.yaml
preferFrozenLockfile: true
blockExoticSubdeps: true
minimumReleaseAge: 1440
minimumReleaseAge: 4320
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The minimumReleaseAge has been increased from 1440 (24 hours) to 4320 (72 hours). This triples the quarantine period for all dependencies in the workspace, which might block legitimate updates for up to 3 days. Since the new minimumReleaseAgeExclude list already allows the fresh prerelease builds of vite-plus and @voidzero-dev/*, this global increase seems unnecessary unless there is a specific reason to delay all other dependency updates. If this was accidental, consider reverting it to 1440.

minimumReleaseAge: 1440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant