chore: upgrade vite-plus to 0.1.20-alpha.4#2
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus suite, including vite and vitest aliases, to version 0.1.20-alpha.4 across the workspace and CLI templates. The review feedback identifies version inconsistencies in the lockfile for the rattail package and notes that @vitest/coverage-istanbul needs to be updated to 4.1.5 in both the workspace catalog and the CLI template to satisfy new peer dependency requirements.
| vue-router: 4.5.1 | ||
| vite: 'npm:@voidzero-dev/vite-plus-core@0.1.18' | ||
| vitest: 'npm:@voidzero-dev/vite-plus-test@0.1.18' | ||
| vite: 'npm:@voidzero-dev/vite-plus-core@0.1.20-alpha.4' |
There was a problem hiding this comment.
The upgrade to vite-plus-core@0.1.20-alpha.4 appears to be inconsistent in the lockfile. For instance, the rattail package is still linked against @voidzero-dev/vite-plus-core@0.1.18 while using vite-plus@0.1.20-alpha.4 (as seen in the lockfile snapshots). This version mismatch between core and plus packages should be resolved by re-running the dependency resolution to ensure all packages use the same version of the suite.
| vite: 'npm:@voidzero-dev/vite-plus-core@0.1.18' | ||
| vitest: 'npm:@voidzero-dev/vite-plus-test@0.1.18' | ||
| vite: 'npm:@voidzero-dev/vite-plus-core@0.1.20-alpha.4' | ||
| vitest: 'npm:@voidzero-dev/vite-plus-test@0.1.20-alpha.4' |
There was a problem hiding this comment.
Upgrading vitest (aliased to @voidzero-dev/vite-plus-test) to 0.1.20-alpha.4 introduces a peer dependency requirement for @vitest/coverage-istanbul: 4.1.5. The current version in the catalog (line 18) is 4.1.4. Consider updating it to 4.1.5 to satisfy the peer dependency and avoid potential warnings or compatibility issues.
| "@vue/runtime-core": "3.5.21", | ||
| "@vitest/coverage-istanbul": "4.1.4", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.18", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.20-alpha.4", |
@varlet/cli
@varlet/icons
@varlet/import-resolver
@varlet/preset-tailwindcss
@varlet/preset-unocss
@varlet/shared
@varlet/touch-emulator
@varlet/ui
@varlet/use
@varlet/vite-plugins
commit: |
Upgrade vite-plus and related packages to 0.1.20-alpha.4 alpha version.