chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#5
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus dependency and its associated sub-packages to use prerelease versions from pkg-pr-new. It also adds release age configurations to the workspace. Feedback indicates that intended overrides for vite and vitest are missing from package.json. Furthermore, the minimumReleaseAge settings in pnpm-workspace.yaml appear to be misplaced and incorrectly indented, which could interfere with workspace detection.
| "tailwindcss-animate": "^1.0.7", | ||
| "typescript": "^6.0.0", | ||
| "vite-plus": "0.1.21", | ||
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633", |
There was a problem hiding this comment.
The pull request description mentions updating vite and vitest aliases to their respective @voidzero-dev/* pkg-pr-new URLs via overrides or resolutions. However, these changes are not present in the package.json file. Without these overrides, the project and its dependencies will continue to use the standard versions of vite and vitest instead of the prerelease versions from the PR.
| minimumReleaseAge: 4320 | ||
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
The minimumReleaseAge configuration is placed in pnpm-workspace.yaml. However, standard package managers like pnpm, npm, and bun do not recognize this file for general configuration; they typically use .npmrc (with the key minimum-release-age) or bunfig.toml. Furthermore, the current indentation level places these new keys at the same level as packages:, which effectively nullifies the packages definition and may break workspace detection. If these settings are intended for the package managers as stated in the PR description, they should be moved to the appropriate configuration files.
Summary
Bump
vite-plusand related@voidzero-dev/*packages to the pkg-pr-new prerelease for vite-plus PR #1633.Updated where applicable:
vite-plus→https://pkg.pr.new/voidzero-dev/vite-plus@1633vitealias →@voidzero-dev/vite-plus-corepkg-pr-new URLvitestalias →@voidzero-dev/vite-plus-testpkg-pr-new URLoverrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsAlso configured
minimum-release-agewith vite-plus /@voidzero-dev/*excluded for pnpm / bun / npm.Test plan