Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#5

Draft
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-pr-1633
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#5
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-pr-1633

Conversation

@fengmk2
Copy link
Copy Markdown
Owner

@fengmk2 fengmk2 commented May 19, 2026

Summary

Bump vite-plus and related @voidzero-dev/* packages to the pkg-pr-new prerelease for vite-plus PR #1633.

Updated where applicable:

  • vite-plushttps://pkg.pr.new/voidzero-dev/vite-plus@1633
  • vite alias → @voidzero-dev/vite-plus-core pkg-pr-new URL
  • vitest alias → @voidzero-dev/vite-plus-test pkg-pr-new URL
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs

Also configured minimum-release-age with vite-plus / @voidzero-dev/* excluded for pnpm / bun / npm.

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 19, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vite-plus dependency and its associated sub-packages to use prerelease versions from pkg-pr-new. It also adds release age configurations to the workspace. Feedback indicates that intended overrides for vite and vitest are missing from package.json. Furthermore, the minimumReleaseAge settings in pnpm-workspace.yaml appear to be misplaced and incorrectly indented, which could interfere with workspace detection.

Comment thread package.json
"tailwindcss-animate": "^1.0.7",
"typescript": "^6.0.0",
"vite-plus": "0.1.21",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description mentions updating vite and vitest aliases to their respective @voidzero-dev/* pkg-pr-new URLs via overrides or resolutions. However, these changes are not present in the package.json file. Without these overrides, the project and its dependencies will continue to use the standard versions of vite and vitest instead of the prerelease versions from the PR.

Comment thread pnpm-workspace.yaml
Comment on lines +3 to +6
minimumReleaseAge: 4320
minimumReleaseAgeExclude:
- vite-plus
- "@voidzero-dev/*"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The minimumReleaseAge configuration is placed in pnpm-workspace.yaml. However, standard package managers like pnpm, npm, and bun do not recognize this file for general configuration; they typically use .npmrc (with the key minimum-release-age) or bunfig.toml. Furthermore, the current indentation level places these new keys at the same level as packages:, which effectively nullifies the packages definition and may break workspace detection. If these settings are intended for the package managers as stated in the PR description, they should be moved to the appropriate configuration files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant