Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new) #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
"validate-npm-package-name": "8.0.0",
"virtua": "0.48.8",
"vite-plugin-pwa": "1.3.0",
"vite-plus": "0.1.20",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using the PR number (@1633) in the pkg-pr-new URL can lead to duplicate package entries in the lockfile. This occurs because internal workspace dependencies within the vite-plus PR build are typically resolved using the specific commit hash. To ensure proper deduplication and lockfile stability, consider using the specific commit hash (428629ad4076431fdbeb332ba7c91935e32f92f6) instead of the PR number.

Suggested change
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@428629ad4076431fdbeb332ba7c91935e32f92f6",

"vue": "3.5.34",
"vue-data-ui": "3.19.8",
"vue-router": "5.0.4"
Expand Down Expand Up @@ -145,7 +145,7 @@
"storybook-i18n": "catalog:storybook",
"typescript": "6.0.2",
"unplugin-vue-markdown": "30.0.0",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.20",
"vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the vite-plus dependency, using the commit hash here will help pnpm deduplicate this package with the internal dependencies of other vite-plus components that are already pointing to the commit-specific build in the lockfile.

Suggested change
"vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633",
"vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@428629ad4076431fdbeb332ba7c91935e32f92f6",

"vue-i18n-extract": "2.0.7",
"vue-tsc": "3.2.6"
},
Expand Down
Loading
Loading