Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#5

Draft
fengmk2 wants to merge 1 commit into
masterfrom
update-vite-plus-prerelease-test-pr-1633
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#5
fengmk2 wants to merge 1 commit into
masterfrom
update-vite-plus-prerelease-test-pr-1633

Conversation

@fengmk2
Copy link
Copy Markdown
Owner

@fengmk2 fengmk2 commented May 19, 2026

Summary

Bump vite-plus and related @voidzero-dev/* packages to the pkg-pr-new prerelease for vite-plus PR #1633.

Updated where applicable:

  • vite-plushttps://pkg.pr.new/voidzero-dev/vite-plus@1633
  • vite alias → @voidzero-dev/vite-plus-core pkg-pr-new URL
  • vitest alias → @voidzero-dev/vite-plus-test pkg-pr-new URL
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs

Also configured minimum-release-age with vite-plus / @voidzero-dev/* excluded for pnpm / bun / npm.

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 19, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pnpm-workspace.yaml and pnpm-lock.yaml files to point to new versions of the @voidzero-dev/vite-plus packages. The reviewer identified a high-severity issue where using the PR number (@1633) in the workspace catalog leads to package duplication in the lockfile because the internal dependencies are pinned to a specific commit hash. To resolve this, the reviewer suggests using the full commit hash URL for all @voidzero-dev/* packages in the catalog to ensure proper deduplication and prevent potential runtime issues.

Comment thread pnpm-workspace.yaml
Comment on lines +14 to +16
vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@1633
vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using the PR number (@1633) in the catalog for vite and vitest is causing package duplication in the lockfile. The vite-plus@1633 package internally pins its dependencies to a specific commit hash (@428629ad4076431fdbeb332ba7c91935e32f92f6), as seen in the pnpm-lock.yaml changes (e.g., lines 3490 and 3502). This results in two versions of the core packages being installed simultaneously. To ensure proper deduplication and avoid potential runtime issues or plugin incompatibilities, it is recommended to use the same commit hash URL for all @voidzero-dev/* packages in the catalog.

  vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@428629ad4076431fdbeb332ba7c91935e32f92f6
  vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@428629ad4076431fdbeb332ba7c91935e32f92f6
  vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@428629ad4076431fdbeb332ba7c91935e32f92f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant