Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@
"oxc-parser": "^0.126.0",
"prettier": "^3.8.3",
"typescript": "^6.0.3",
"vite-plus": "^0.1.18",
"vite-plus": "0.1.21-alpha.6",
"vitest": "^4.1.4"
},
"resolutions": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.6",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.6"
Comment on lines +44 to +45
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The resolutions for vite and vitest have been updated to a specific alpha version, which is a good practice for reproducibility. However, vitest is also listed as a direct dependency in devDependencies (line 41) with version ^4.1.4.

In Yarn 4, when aliasing a direct dependency to another package (like @voidzero-dev/vite-plus-test), it is more idiomatic and clearer to use the npm: protocol directly in the devDependencies entry. This avoids the confusion of having a misleading version string (^4.1.4) that is immediately overridden by a resolution.

Consider updating the devDependencies entry for vitest to use the alias directly and removing it from resolutions if it's not needed for transitive dependencies.

},
"packageManager": "yarn@4.13.0"
}
Loading
Loading