Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new) #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
"vite-plugin-checker": "0.13.0",
"vite-plugin-electron": "0.29.1",
"vite-plugin-electron-renderer": "0.14.7",
"vite-plus": "0.1.21",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request summary mentions that the vite and vitest aliases were updated to pkg-pr-new URLs, but they remain as version strings (8.0.13 and 4.1.6) in the devDependencies. If the intention was to use the prerelease builds for these packages as well, they should be updated to their respective URLs or handled via overrides.

"vitest": "4.1.6",
"zustand": "5.0.13"
},
Expand Down
116 changes: 67 additions & 49 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@ allowBuilds:
'@primer/primitives': false
electron: true
electron-winstaller: true
blockExoticSubdeps: false
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Setting blockExoticSubdeps to false allows transitive dependencies to be resolved from arbitrary URLs. This significantly increases the attack surface for supply chain attacks by bypassing registry integrity checks for sub-dependencies. While this is necessary for testing pkg-pr-new builds, it should be avoided in production-bound branches.

minimumReleaseAge: 1440
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The minimumReleaseAge is set to 1440 minutes (24 hours). This is extremely restrictive and will block any legitimate dependency updates or critical security hotfixes for a full day after their release. A shorter duration, such as 60 minutes, is usually sufficient to mitigate automated malware bursts while maintaining development velocity.

minimumReleaseAge: 60

minimumReleaseAgeExclude:
- vite-plus
- '@voidzero-dev/*'
- caniuse-lite
Loading