chore(deps): bump vite-plus to 0.1.21-alpha.7#3
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the vite, vite-plus, and vitest dependencies to version 0.1.21-alpha.7 and introduces a new minimumReleaseAgeExclude configuration in pnpm-workspace.yaml files. Feedback was provided regarding the non-standard nature of the minimumReleaseAgeExclude key and its naming convention, suggesting a plural form to match other list-based keys. Additionally, it was recommended to use version ranges instead of pinned versions for alpha releases in the template to allow for automatic updates within the alpha cycle.
| vite-plus: 0.1.21-alpha.7 | ||
| vitest: npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7 | ||
|
|
||
| minimumReleaseAgeExclude: |
There was a problem hiding this comment.
The minimumReleaseAgeExclude field is not a standard top-level configuration key for pnpm-workspace.yaml in pnpm or Bun. Pnpm 10+ uses minimum-release-age (typically configured in .npmrc or under the pnpm field in package.json), and it does not officially support an exclusion list or glob patterns in this file. If this is a custom configuration for the vp tool, please verify the naming; the PR description mentions both minimumReleaseAgeExclude and minimumReleaseAgeExcludes. Most list-based keys in this file (like packages or onlyBuiltDependencies) use plural forms.
| vite: npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7 | ||
| vite-plus: 0.1.21-alpha.7 | ||
| vitest: npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7 |
There was a problem hiding this comment.
The dependency versions in this template have been changed from ranges (^0.1.20) to pinned versions (0.1.21-alpha.7). While pinning is appropriate for alpha releases to ensure stability, it means projects created from this template will not automatically receive updates (e.g., alpha.8). Consider using a range like ^0.1.21-alpha.0 to allow the template to track compatible alpha updates while staying within the current release cycle.
vite: npm:@voidzero-dev/vite-plus-core@^0.1.21-alpha.0
vite-plus: ^0.1.21-alpha.0
vitest: npm:@voidzero-dev/vite-plus-test@^0.1.21-alpha.0| vite-plus: 0.1.21-alpha.7 | ||
| vitest: npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7 | ||
|
|
||
| minimumReleaseAgeExclude: |
There was a problem hiding this comment.
The minimumReleaseAgeExclude field is not a standard top-level configuration key for pnpm-workspace.yaml. If this is intended for the vp tool, please verify if the key should be plural (minimumReleaseAgeExcludes) to match the naming convention of other list-based keys in this file and the mention in the PR description.
commit: |
1 participant
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan