Skip to content

chore: upgrade vite-plus to 0.1.20-alpha.4#1

Draft
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-alpha-0.1.20-alpha.4
Draft

chore: upgrade vite-plus to 0.1.20-alpha.4#1
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-alpha-0.1.20-alpha.4

Conversation

@fengmk2
Copy link
Copy Markdown
Owner

@fengmk2 fengmk2 commented Apr 28, 2026

Upgrade vite-plus and related packages to 0.1.20-alpha.4 alpha version.

@fengmk2 fengmk2 self-assigned this Apr 28, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request pins the versions of vite-plus, vite, and vitest to a specific alpha release (0.1.20-alpha.4) across multiple package.json files. A review comment suggests using a version range for the peerDependency in packages/dev/package.json to prevent potential dependency conflicts and allow for compatible updates.

Comment thread packages/dev/package.json
"jsdom": "*",
"typescript": "*",
"vite-plus": "*"
"vite-plus": "0.1.20-alpha.4"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning a peerDependency to an exact alpha version is very restrictive and can lead to dependency conflicts for consumers of this package. Since other peer dependencies in this file use version ranges (e.g., >=8.0.0-beta.26), consider using a range here as well to allow for compatible updates of vite-plus without requiring a new release of @faasjs/dev.

Suggested change
"vite-plus": "0.1.20-alpha.4"
"vite-plus": ">=0.1.20-alpha.4"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant