chore(deps): bump vite-plus to 0.1.21-alpha.6#2
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the versions of vite, vite-plus, and vitest to 0.1.21-alpha.6 in both devDependencies and pnpm.overrides. The reviewer suggests using the $package syntax in the overrides section to reference versions defined in devDependencies, which helps prevent version mismatch and reduces duplication. Additionally, it is recommended to include vite-plus in the overrides for consistency.
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.6", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.6" |
There was a problem hiding this comment.
To improve maintainability and ensure version consistency across the dependency tree, consider using the $package syntax in the pnpm.overrides section. This allows you to reference the versions already defined in devDependencies, avoiding duplication and the risk of versions falling out of sync during future updates. Additionally, including vite-plus in the overrides ensures that any transitive dependencies also use the specified alpha version. If your workspace uses catalogs (as mentioned in the PR description), consider using the catalog: protocol instead.
"vite": "$vite",
"vite-plus": "$vite-plus",
"vitest": "$vitest"
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.6.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsTest plan