chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#5
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus dependency to a specific build URL across multiple packages and introduces release age policies in .npmrc and pnpm-workspace.yaml. The review feedback identifies an incorrect configuration key in .npmrc, suggests using pnpm catalogs to manage the repeated dependency update more efficiently, and highlights unit inconsistencies and non-standard fields within the workspace configuration.
| @@ -1 +1,3 @@ | |||
| node-linker=hoisted | |||
| min-release-age=259200 | |||
| min-release-age-exclude=vite-plus,@voidzero-dev/* | |||
There was a problem hiding this comment.
| "@changesets/cli": "^2.30.0", | ||
| "sherif": "^1.2.0", | ||
| "vite-plus": "latest" | ||
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633" |
There was a problem hiding this comment.
The PR description mentions updating vite and vitest aliases in overrides / resolutions, but these changes are missing from the diff. Please ensure these were not accidentally omitted from the commit.
Also, since vite-plus is updated to the same URL across multiple packages, consider using pnpm catalogs (v10+) in pnpm-workspace.yaml to manage this dependency centrally and avoid repetitive updates.
| minimumReleaseAge: 4320 | ||
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
The fields minimumReleaseAge and minimumReleaseAgeExclude are not standard for pnpm-workspace.yaml. Additionally, there is a unit inconsistency: .npmrc uses seconds (259200), while this file uses minutes (4320).
If these are intended for pnpm, they should be removed as they are already configured in .npmrc. If they are for a custom tool, consider standardizing the units and naming to match the package manager's configuration to avoid confusion and maintenance errors.
commit: |
Summary
Bump
vite-plusand related@voidzero-dev/*packages to the pkg-pr-new prerelease for vite-plus PR #1633.Updated where applicable:
vite-plus→https://pkg.pr.new/voidzero-dev/vite-plus@1633vitealias →@voidzero-dev/vite-plus-corepkg-pr-new URLvitestalias →@voidzero-dev/vite-plus-testpkg-pr-new URLoverrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsAlso configured
minimum-release-agewith vite-plus /@voidzero-dev/*excluded for pnpm / bun / npm.Test plan