Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#5

Draft
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-pr-1633
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#5
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-pr-1633

Conversation

@fengmk2
Copy link
Copy Markdown
Owner

@fengmk2 fengmk2 commented May 19, 2026

Summary

Bump vite-plus and related @voidzero-dev/* packages to the pkg-pr-new prerelease for vite-plus PR #1633.

Updated where applicable:

  • vite-plushttps://pkg.pr.new/voidzero-dev/vite-plus@1633
  • vite alias → @voidzero-dev/vite-plus-core pkg-pr-new URL
  • vitest alias → @voidzero-dev/vite-plus-test pkg-pr-new URL
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs

Also configured minimum-release-age with vite-plus / @voidzero-dev/* excluded for pnpm / bun / npm.

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 19, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vite-plus dependency to a specific build URL across multiple packages and introduces release age policies in .npmrc and pnpm-workspace.yaml. The review feedback identifies an incorrect configuration key in .npmrc, suggests using pnpm catalogs to manage the repeated dependency update more efficiently, and highlights unit inconsistencies and non-standard fields within the workspace configuration.

Comment thread .npmrc
@@ -1 +1,3 @@
node-linker=hoisted
min-release-age=259200
min-release-age-exclude=vite-plus,@voidzero-dev/*
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In pnpm v10, the correct configuration key for excluding packages from the release age policy is min-release-age-policy-exclude. The current key min-release-age-exclude is likely invalid and will be ignored by the package manager.

min-release-age-policy-exclude=vite-plus,@voidzero-dev/*

Comment thread package.json
"@changesets/cli": "^2.30.0",
"sherif": "^1.2.0",
"vite-plus": "latest"
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The PR description mentions updating vite and vitest aliases in overrides / resolutions, but these changes are missing from the diff. Please ensure these were not accidentally omitted from the commit.

Also, since vite-plus is updated to the same URL across multiple packages, consider using pnpm catalogs (v10+) in pnpm-workspace.yaml to manage this dependency centrally and avoid repetitive updates.

Comment thread pnpm-workspace.yaml
Comment on lines +4 to +7
minimumReleaseAge: 4320
minimumReleaseAgeExclude:
- vite-plus
- "@voidzero-dev/*"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fields minimumReleaseAge and minimumReleaseAgeExclude are not standard for pnpm-workspace.yaml. Additionally, there is a unit inconsistency: .npmrc uses seconds (259200), while this file uses minutes (4320).

If these are intended for pnpm, they should be removed as they are already configured in .npmrc. If they are for a custom tool, consider standardizing the units and naming to match the package manager's configuration to avoid confusion and maintenance errors.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 19, 2026

Open in StackBlitz

npm i https://pkg.pr.new/bippy@5

commit: 4d2e28b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant