You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request pins the version of vite-plus to 0.1.21-alpha.7 across multiple packages and updates pnpm-workspace.yaml to exclude vite-plus and @voidzero-dev/* from minimum release age checks. The reviewer suggests centralizing the vite-plus version and its aliases within a pnpm catalog in pnpm-workspace.yaml to improve maintainability and ensure consistency across the monorepo, rather than hardcoding the version in each individual package.json file.
The reason will be displayed to describe this comment to others. Learn more.
The PR description mentions updating pnpm-workspace.yaml catalogs, but no catalog section is present in the file. Since vite-plus is being updated to the same version across multiple packages, it is more maintainable to define it in a centralized pnpm catalog. This also provides a clear place to manage the vite and vitest aliases mentioned in the summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan