chore(deps): bump vite-plus to 0.1.21-alpha.6#3
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request pins the vite-plus dependency to version 0.1.21-alpha.6 across several packages in the monorepo. The reviewer recommends adopting the pnpm 10 catalog: protocol to centralize version management and points out that changes to pnpm-workspace.yaml mentioned in the PR description are missing from the current diff.
| "@changesets/cli": "^2.30.0", | ||
| "sherif": "^1.2.0", | ||
| "vite-plus": "latest" | ||
| "vite-plus": "0.1.21-alpha.6" |
There was a problem hiding this comment.
The PR description mentions updating pnpm-workspace.yaml catalogs and pnpm.overrides for vite and vitest aliases, but these changes are missing from the diff. Please ensure all intended files are included to avoid inconsistencies or build issues with the alpha release. Additionally, since the project uses pnpm 10, consider using the catalog: protocol for vite-plus to centralize its version management across the monorepo.
| "vite-plus": "0.1.21-alpha.6" | |
| "vite-plus": "catalog:" |
| "terser": "^5.36.0", | ||
| "tsx": "^4.21.0", | ||
| "vite-plus": "latest" | ||
| "vite-plus": "0.1.21-alpha.6" |
There was a problem hiding this comment.
Since the project uses pnpm 10 and this dependency is shared across multiple packages, consider using the catalog: protocol. This centralizes the version management in pnpm-workspace.yaml and avoids manual updates in each package.json. This assumes vite-plus has been added to the workspace catalog as mentioned in the PR description.
| "vite-plus": "0.1.21-alpha.6" | |
| "vite-plus": "catalog:" |
| "tailwindcss": "4.0.0-beta.8", | ||
| "typescript": "^5.7.3", | ||
| "vite-plus": "latest" | ||
| "vite-plus": "0.1.21-alpha.6" |
There was a problem hiding this comment.
Consider using the catalog: protocol for vite-plus to maintain consistency across the monorepo and leverage pnpm 10 catalogs as mentioned in the PR description.
| "vite-plus": "0.1.21-alpha.6" | |
| "vite-plus": "catalog:" |
| "tw-animate-css": "^1.4.0", | ||
| "typescript": "^5", | ||
| "vite-plus": "latest" | ||
| "vite-plus": "0.1.21-alpha.6" |
There was a problem hiding this comment.
Consider using the catalog: protocol for vite-plus to maintain consistency across the monorepo and leverage pnpm 10 catalogs as mentioned in the PR description.
| "vite-plus": "0.1.21-alpha.6" | |
| "vite-plus": "catalog:" |
commit: |
1 participant
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.6.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsTest plan