chore(deps): bump vite-plus to 0.1.21-alpha.7#3
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the versions for vite, vitest, and vite-plus in the pnpm workspace catalog from 'latest' to specific alpha versions. It also introduces a new configuration field, 'minimumReleaseAgeExclude', to exclude specific packages from release age checks. The reviewer suggested renaming this new field to 'minimumReleaseAgeExcludes' to ensure naming consistency with other pluralized list fields in the configuration file.
| overrides: | ||
| vite: "catalog:" | ||
| vitest: "catalog:" | ||
| minimumReleaseAgeExclude: |
There was a problem hiding this comment.
The field name minimumReleaseAgeExclude is singular, which is inconsistent with other list-based fields in this file such as packages, overrides, and peerDependencyRules. Additionally, the pull request description mentions both minimumReleaseAgeExclude and minimumReleaseAgeExcludes, suggesting some uncertainty. For consistency with the existing file structure and to ensure the configuration is correctly recognized by the intended tools, consider using the plural form minimumReleaseAgeExcludes.
minimumReleaseAgeExcludes:
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan