fix(express): forward access token on req.user in requireAuth#53
Merged
Conversation
requireAuth built req.user without the inner access token, so getSeamlessUser and buildServiceAuthorization could not send a bearer credential to the auth server. Trusted server adapters received a "Missing bearer" error and every authenticated route returned 401. Attach payload.token as req.user.token, add token to the SeamlessAuthUser type, and cover it with a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
requireAuthverified the access cookie and populatedreq.user, but it omitted the inner access token from the cookie payload. Downstream,getSeamlessUserandbuildServiceAuthorizationreadreq.user.tokento build the bearer credential for calls to the auth server. With that field missing, the auth server responded with "Missing bearer" and everyrequireUser/getSeamlessUser-protected route on trusted server adapters returned 401.This surfaced in the Seamless Auth Portal API: after a successful login the session cookies were set, but
/users/me(and all authenticated routes) returned 401, so users never appeared logged in.Fix
requireAuthnow attaches the inner access token asreq.user.token.SeamlessAuthUsergains an optionaltokenfield (additive, non-breaking).req.user.tokenis populated from the cookie payload.Testing
pnpm --filter @seamless-auth/express testpasses (12 suites, 31 tests)./users/mewith 200.Release
Includes a patch changeset for
@seamless-auth/express(core is linked, so both bump to 0.7.1).