Conversation
… can't write everything with AI)
Registration now starts with just an email; verifying the registration email OTP completes sign-up and returns a session. Add verifyRegistrationOtpHandler (core) and verifyRegistrationOtp (express) so /otp/verify-email-otp and /otp/verify-phone-otp set the session cookies — they previously proxied without cookies, leaving browser users unauthenticated after registering. The shared verify helper tolerates a phone-first step that returns no session yet.
authFetch now parses response bodies defensively: a plain-text error (e.g. a
rate-limited 429) or an empty body (204) no longer throws in handlers that read
the body before checking status, which previously crashed the adapter process.
Non-JSON -> { message: text }, empty -> undefined. Adds authFetch regression tests.
Mount the TOTP surface in @seamless-auth/express so frontends can drive TOTP enrollment, management, and TOTP-based step-up verification: - GET /auth/totp/status - POST /auth/totp/enroll/start - POST /auth/totp/enroll/verify - POST /auth/totp/disable - POST /auth/totp/verify-mfa These proxy the caller's access session upstream, matching the step-up route pattern. They update server-side state only and mint no new session cookies. TOTP as a login second factor is intentionally out of scope: the auth API does not gate login on TOTP today, so /totp/verify-login has no trigger yet. @seamless-auth/core gains the matching access-cookie requirements and now matches cookie requirements case-insensitively. Express route matching is case-insensitive by default, so a client path whose casing differed from the mounted route (e.g. /webauthn vs /webAuthn) previously failed the case-sensitive requirement lookup, silently skipped cookie loading, and broke the request. The lookup is normalized to lower case on both sides. Adds core unit tests for the TOTP requirements and case-insensitive matching, and an express integration test covering each proxied TOTP route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.