fix(magic-link): build redirect from a dedicated frontend_url config#75
Merged
Conversation
Magic links were built from origins[0], so the emailed link pointed at whichever origin happened to be first, which could be a non-frontend host (for example an API origin). Add an optional frontend_url system config (env FRONTEND_URL) and use it as the base for the redirect, falling back to origins[0] when unset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Magic-link emails were built from
config.origins[0], so the emailed link pointed at whichever origin happened to be first. Depending on origin ordering that can be a non-frontend host (for example an API origin), so the link did not land on the page that verifies it.Change
frontend_urlsystem config (envFRONTEND_URL), wired through the schema and env map.magicLinks.tsnow builds the redirect fromconfig.frontend_url ?? config.origins[0], so it uses the real frontend URL and falls back to the old behavior when unset (backward compatible).frontend_urlwins regardless of origin order.Testing
npm run build,npm run lint,npm run typecheck,npm run format:checkall pass.npm run test:runpasses (73 test files), including the new magic-link case.Release
Includes a patch changeset for
seamless-auth-api.