fix(redaction): redact otp/verificationToken query params and document policy#68
Merged
Conversation
…olicy Add otp and verificationToken to the URL query-parameter redaction rule so any future route that carries them in a URL is scrubbed from logs (defense in depth; no current route does). Add a Logging and Redaction section to the architecture doc so the policy is discoverable from the main docs. Closes #60
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60
Summary
The central logger already redacts
bootstrapToken=,token=,code=,state=,salt=, magic-link verify tokens, emails, and phone numbers (verified during the security survey). Two small follow-ups from that survey:otpandverificationTokento the URL query-parameter redaction rule insrc/utils/redaction.ts. No current route carries these in a query string, so this is defense-in-depth for future routes, not a live leak.docs/architecture.md, linking to the operator detail inproduction-operations.md.Testing
otpandverificationTokenquery params are redacted.redaction.spec.tspasses; typecheck + lint clean.