Skip to content

migrate to amphp#746

Open
robberphex wants to merge 4 commits intofelixfbecker:masterfrom
robberphex:amphp
Open

migrate to amphp#746
robberphex wants to merge 4 commits intofelixfbecker:masterfrom
robberphex:amphp

Conversation

@robberphex
Copy link
Copy Markdown

No description provided.

@felixfbecker
Copy link
Copy Markdown
Owner

Thanks for this! Could you give some explanation for this change in the PR description? I.e. what is the motivation/benefit, what are the high-level required changes this PR implements, are there any drawbacks?

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 73.40720% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.81%. Comparing base (9dc1656) to head (a5433b2).

Files with missing lines Patch % Lines
src/Indexer.php 49.27% 35 Missing ⚠️
src/Cache/FileSystemCache.php 0.00% 12 Missing ⚠️
src/LanguageServer.php 73.07% 7 Missing ⚠️
src/Server/Workspace.php 58.82% 7 Missing ⚠️
src/Cache/ClientCache.php 0.00% 6 Missing ⚠️
src/ComposerScripts.php 0.00% 6 Missing ⚠️
src/Server/TextDocument.php 91.07% 5 Missing ⚠️
src/Client/XCache.php 0.00% 4 Missing ⚠️
src/ProtocolStreamReader.php 84.61% 4 Missing ⚠️
src/PhpDocumentLoader.php 80.00% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #746      +/-   ##
============================================
- Coverage     82.12%   80.81%   -1.32%     
- Complexity      935      995      +60     
============================================
  Files            44       45       +1     
  Lines          2154     2168      +14     
============================================
- Hits           1769     1752      -17     
- Misses          385      416      +31     
Files with missing lines Coverage Δ
src/Client/TextDocument.php 100.00% <100.00%> (ø)
src/Client/Window.php 66.66% <100.00%> (ø)
src/Client/Workspace.php 100.00% <100.00%> (ø)
src/ContentRetriever/ClientContentRetriever.php 100.00% <100.00%> (ø)
...rc/ContentRetriever/FileSystemContentRetriever.php 100.00% <100.00%> (ø)
src/Event/MessageEvent.php 100.00% <100.00%> (ø)
src/FilesFinder/ClientFilesFinder.php 100.00% <100.00%> (ø)
src/FilesFinder/FileSystemFilesFinder.php 100.00% <100.00%> (ø)
src/Index/AbstractAggregateIndex.php 62.79% <100.00%> (-23.26%) ⬇️
src/Index/DependenciesIndex.php 13.33% <ø> (ø)
... and 17 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants