feat: Warn when the registry server starts with authentication disabled#6512
Open
AgentGymLeader wants to merge 1 commit into
Open
feat: Warn when the registry server starts with authentication disabled#6512AgentGymLeader wants to merge 1 commit into
AgentGymLeader wants to merge 1 commit into
Conversation
The registry server accepts control-plane writes such as applying feature views, which materialize user-provided transformation code on the registry host. When authentication is disabled (auth type no_auth) it accepts those requests unauthenticated, so it is only safe to run inside a trusted network boundary. Nothing in the startup path signals this today. Add a startup warning emitted when the auth manager type is NONE, plus a unit test covering that the warning fires for NONE and stays silent for an authenticated type. Behavior is otherwise unchanged. Signed-off-by: FugoP <264910004+AgentGymLeader@users.noreply.github.com>
|
I like that this keeps the behavior unchanged and only raises operator visibility. One regression I would add is a thin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a startup warning when the gRPC registry server is launched with authentication disabled (
authtypeno_auth).Why
The registry server accepts control-plane writes such as applying feature views. Materializing those definitions loads user-provided transformation code on the registry host. When authentication is disabled the server accepts these requests unauthenticated, so it is only safe to run inside a trusted network boundary. Today nothing in the startup path signals this to the operator — the only startup logs are info-level TLS/non-TLS messages.
What
_warn_if_auth_disabled(auth_manager_type), which emits a singlelogger.warningwhen the auth manager type isNONE.start_serverright after the auth type is resolved.NONEand stays silent for an authenticated type.Behavior is unchanged; this only adds an operator-facing warning. This is a defense-in-depth / operator-visibility improvement, not a behavior change.