Skip to content

🛠️ Refactor: SDK Core - Centralize Endpoint Path Building and Not Found Logic (DRY)#857

Draft
fderuiter wants to merge 1 commit intomainfrom
refactor-centralize-path-building-12189503407201544417
Draft

🛠️ Refactor: SDK Core - Centralize Endpoint Path Building and Not Found Logic (DRY)#857
fderuiter wants to merge 1 commit intomainfrom
refactor-centralize-path-building-12189503407201544417

Conversation

@fderuiter
Copy link
Copy Markdown
Owner

🛠️ Refactor: SDK Core - Centralize Endpoint Path Building and Not Found Logic (DRY)\n\n♻️ DRY Gains:\nCollapsed identical path building and 404 raising logic across PathGetEndpointMixin, ListEndpointMixin, FilterGetEndpointMixin, JobsEndpoint, and RecordsEndpoint into EndpointABC. \n\n🧱 SOLID:\nEnforced Interface Segregation and Dependency Inversion by requiring subclasses to implement base path properties while abstracting validation away from the mixins. Mixins now only depend on _get_endpoint_path and _raise_not_found rather than handling raw path generation.\n\n📉 Diff:\nRemoved duplicated generic path strings, redundant checks, and inline imports. No changes to observable behavior.


PR created automatically by Jules for task 12189503407201544417 started by @fderuiter

…nd Logic (DRY)\n\n♻️ DRY: Collapsed identical path building and 404 raising logic across `PathGetEndpointMixin`, `ListEndpointMixin`, `FilterGetEndpointMixin`, `JobsEndpoint`, and `RecordsEndpoint` into `EndpointABC`.\n🧱 SOLID: Enforced Interface Segregation and Dependency Inversion by requiring subclasses to implement base path properties while abstracting validation away from the mixins.\n📉 Diff: Removed duplicated generic path strings, redundant checks, and inline imports.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant