🛠️ Refactor: SDK Core - Centralize Endpoint Path Building and Not Found Logic (DRY)#857
🛠️ Refactor: SDK Core - Centralize Endpoint Path Building and Not Found Logic (DRY)#857
Conversation
…nd Logic (DRY)\n\n♻️ DRY: Collapsed identical path building and 404 raising logic across `PathGetEndpointMixin`, `ListEndpointMixin`, `FilterGetEndpointMixin`, `JobsEndpoint`, and `RecordsEndpoint` into `EndpointABC`.\n🧱 SOLID: Enforced Interface Segregation and Dependency Inversion by requiring subclasses to implement base path properties while abstracting validation away from the mixins.\n📉 Diff: Removed duplicated generic path strings, redundant checks, and inline imports. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🛠️ Refactor: SDK Core - Centralize Endpoint Path Building and Not Found Logic (DRY)\n\n♻️ DRY Gains:\nCollapsed identical path building and 404 raising logic across
PathGetEndpointMixin,ListEndpointMixin,FilterGetEndpointMixin,JobsEndpoint, andRecordsEndpointintoEndpointABC. \n\n🧱 SOLID:\nEnforced Interface Segregation and Dependency Inversion by requiring subclasses to implement base path properties while abstracting validation away from the mixins. Mixins now only depend on_get_endpoint_pathand_raise_not_foundrather than handling raw path generation.\n\n📉 Diff:\nRemoved duplicated generic path strings, redundant checks, and inline imports. No changes to observable behavior.PR created automatically by Jules for task 12189503407201544417 started by @fderuiter