🛠️ Refactor: Endpoints - Collapse list logic and remove duplication#621
Closed
🛠️ Refactor: Endpoints - Collapse list logic and remove duplication#621
Conversation
Collapsed redundant list implementation logic in `UsersEndpoint` and `RecordsEndpoint` by introducing `_extract_special_params` hook in `ListGetEndpointMixin`. Extracted duplicate site filtering logic in `SubjectsEndpoint` to a shared helper method. This enforces DRY and Open/Closed principles without altering behavior. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Collapsed redundant list implementation logic in `UsersEndpoint` and `RecordsEndpoint` by introducing `_extract_special_params` hook in `ListGetEndpointMixin`. Extracted duplicate site filtering logic in `SubjectsEndpoint` to a shared helper method. This enforces DRY and Open/Closed principles without altering behavior. Fixed unused imports in `UsersEndpoint`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Collapsed redundant list implementation logic in `UsersEndpoint` and `RecordsEndpoint` by introducing `_extract_special_params` hook in `ListGetEndpointMixin`. Extracted duplicate site filtering logic in `SubjectsEndpoint` to a shared helper method. This enforces DRY and Open/Closed principles without altering behavior. Fixed unused imports in `UsersEndpoint`. Fixed mypy errors in `tests/unit/test_core_paginator.py`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Collapsed redundant list implementation logic in `UsersEndpoint` and `RecordsEndpoint` by introducing `_extract_special_params` hook in `ListGetEndpointMixin`. Extracted duplicate site filtering logic in `SubjectsEndpoint` to a shared helper method. This enforces DRY and Open/Closed principles without altering behavior. Fixed unused imports in `UsersEndpoint`. Fixed mypy errors in `tests/unit/test_core_paginator.py`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Collapsed redundant list implementation logic in `UsersEndpoint` and `RecordsEndpoint` by introducing `_extract_special_params` hook in `ListGetEndpointMixin`. Extracted duplicate site filtering logic in `SubjectsEndpoint` to a shared helper method. This enforces DRY and Open/Closed principles without altering behavior. Fixed unused imports in `UsersEndpoint`. Fixed mypy errors in `tests/unit/test_core_paginator.py`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
fderuiter
deleted the
refactor/endpoints-collapse-duplication-9015745037105151916
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors several endpoints to remove code duplication and enforce SOLID principles.
Changes:
ListGetEndpointMixin: Added_extract_special_paramshook to allow subclasses to inject custom query parameters without overriding the entire_list_implmethod (Open/Closed Principle).UsersEndpoint: Removed_list_imploverride and used_extract_special_paramsto handleincludeInactive.RecordsEndpoint: Removed_list_imploverride and used_extract_special_paramsto handlerecordDataFilter.SubjectsEndpoint: Extracted duplicate filtering logic fromlist_by_siteandasync_list_by_siteinto a shared_filter_by_sitemethod (DRY).Verification:
tests/unit/endpoints/).includeInactive(Users) andrecordDataFilter(Records) remains functionally equivalent (missing flag defaults to false/empty).PR created automatically by Jules for task 9015745037105151916 started by @fderuiter