Skip to content

Use tap-local CI for Homebrew updates#56

Merged
faustodavid merged 1 commit into
mainfrom
feature/secure-homebrew-tap-ci
Jun 7, 2026
Merged

Use tap-local CI for Homebrew updates#56
faustodavid merged 1 commit into
mainfrom
feature/secure-homebrew-tap-ci

Conversation

@faustodavid
Copy link
Copy Markdown
Owner

Summary

  • remove cross-repo Homebrew tap writes from the public smith workflow
  • keep release tag/version validation in smith
  • document that formula updates run from the tap repo using its own short-lived GITHUB_TOKEN

Security

  • no HOMEBREW_TAP_TOKEN secret is required or referenced in this public repo
  • smith workflow permissions remain contents: read

Validation

  • make check
  • actionlint .github/workflows/homebrew-formula.yml
  • workflow YAML parse

@faustodavid faustodavid merged commit ad4bac1 into main Jun 7, 2026
8 checks passed
@faustodavid faustodavid deleted the feature/secure-homebrew-tap-ci branch June 7, 2026 19:31
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 703b14f64c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if: ${{ steps.formula.outputs.changed == 'false' }}
run: echo "Tap formula is already current for ${{ steps.release.outputs.tag }}."
echo "Release ${RELEASE_TAG}@${RELEASE_REVISION} is valid."
echo "Update faustodavid/homebrew-tap with its Update Smith Formula workflow."
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Trigger the tap update instead of only logging it

For a normal v* release tag this workflow now stops after printing the handoff message, and the referenced tap workflow is dispatch-only, so nothing in this tag-push path actually invokes it. That means the Homebrew formula remains pinned to the previous release unless a maintainer manually runs the tap workflow, which regresses the automatic formula update that the removed steps provided.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant