Allow PAT-authenticated clients to create shares via JSON API#36
Merged
Conversation
Adds POST /links/:link_id/shares.json to the JSON API so a user holding a personal access token can create shareable links for a link (paired with the existing GET endpoint for querying them). - whitelist shares#create in API_ENDPOINTS - SharesController#create now responds to JSON with 201/422 - shortened_url assignment is rescued so a Rebrandly failure doesn't leak a 500 after the share is already persisted - request specs cover success, validation errors, auth, and the shorten-failure path Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /links/:link_id/shares.jsonso a user holding a personal access token can create shareable links for a link, paired with the existingGET /links/:link_id/shares.jsonfor querying them.SharesController#createnow responds to both HTML and JSON (returns201 Createdwith the share payload, or422witherrors).nullshortened_urland a warning is logged.Test plan
bundle exec rspec— 38 examples, 0 failurescurl -X POST -H "Authorization: Bearer <token>" -H "Accept: application/json" -d 'share[utm_source]=...' /links/<id>/shares.jsonand confirm a 201 response with the share JSON🤖 Generated with Claude Code