Flask support!#8
Merged
Merged
Conversation
Here move away from app.py at the top-level in favor of an examples directory. We clone the functionality of the bottle example and port it to flask. Things don't work out of the box, and we define a set of hack shims for now that manage to make it so at least a very basic service can be written in flask!
* Remove `integration` marker that breaks test runs: `'integration' not found in `markers` configuration option` * Remove reference to `app.wasm` make target that no longer exists. `make test` should suffice.
Member
|
I'm inclined to merge this so we can work further on the stuff it adds. It's no more broken than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here move away from app.py at the top-level in favor of an examples directory. We clone the functionality of the bottle example and port it to flask. Things don't work out of the box, and we define a set of hack shims for now that manage to make it so at least a very basic service can be written in flask!
Feel free to make modifications while I'm away if you want or I'll be happy to address feedback when I return. Long term I don't expect we'll want the shim present, but I think for this time it still is valuable to prove out the pieces that are missing.