Add logging support#35
Merged
Merged
Conversation
posborne
force-pushed
the
posborne/logging-endpoints
branch
from
b2fe061 to
6d6c3e4
Compare
erikrose
reviewed
Jan 30, 2026
Member
erikrose
left a comment
erikrose
left a comment
There was a problem hiding this comment.
Seems reasonable. Thank you!
erikrose
reviewed
Feb 17, 2026
erikrose
reviewed
Feb 17, 2026
Member
|
Here are the few logging tests I ported as part of developing #43: |
This change introduces both low-level logging endpoint access and a higher-level interface to write logs using python's standard logging facade. Also included are test cases and example code to help facilitate that testing. A callable mapper is provided in order to support users that may want to map logger's by name to more than a single fastly logging endpoint.
Here, there was an assumption that examples/logging/logging.py would exist. It doesn't as this created a namespace conflict; just remove the unecessary check.
posborne
force-pushed
the
posborne/logging-endpoints
branch
from
6d6c3e4 to
ce98741
Compare
Member
Author
Member
|
Order of landing the two shouldn't matter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces both low-level logging endpoint access and a higher-level interface to write logs using python's standard logging facade. Also included are test cases and example code to help facilitate that testing.
A callable mapper is provided in order to support users that may want to map logger's by name to more than a single fastly logging endpoint.
This will need to be tweaked once we have changes for generated exceptions but I expect that to be minimal.