Bump Wit 0.0.0 prerelease.0, WSGI Reuse Fixes#25
Merged
Conversation
posborne
force-pushed
the
posborne/wit-0.0.0-prerelease.0
branch
from
a3c1d53 to
7313acd
Compare
posborne
changed the title
posborne
force-pushed
the
posborne/wit-0.0.0-prerelease.0
branch
from
b1c1e30 to
d88f8fa
Compare
erikrose
reviewed
Dec 17, 2025
Debugging failures, I've found multiple times that I wanted additional context, increase it.
A bit more DRY and should avoid doing what I just did and missing an update to the cache key.
posborne
force-pushed
the
posborne/wit-0.0.0-prerelease.0
branch
from
d88f8fa to
39ee544
Compare
erikrose
approved these changes
Dec 17, 2025
Member
erikrose
left a comment
erikrose
left a comment
There was a problem hiding this comment.
In case you were wanting another review, here it is! :-D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes bump the WIT definitions to match Viceroy 0.6.2 (0.0.0 prerelease.0) and do a few mechanical updates to the tree to work with those latest defintions.
More substantially, the WIT update caused failures in the WSGI code's
http_req.sendworkaround to attempt to do a resource.drop on requests. For that, I reworked the WSGI code to more carefully clean up references to the request resource in order to ensure that between requests we'll hit the finalizer code for those objects that is already part of what is provided by componentize-py (which will call resource.drop). The behavior if there are remaining references is based onassert_on_uncollected_resourceto either:Prior to hitting those paths, if the object is uncollected we will do a gc collection in the off chance that it is caught up in a reference cycle. I don't expect this path is likely to be hit often in practice.