Skip to content

fix: use named import for connect-redis v8.x#343

Merged
Tony133 merged 1 commit into
mainfrom
fix/connect-redis-named-export-types
Jul 13, 2026
Merged

fix: use named import for connect-redis v8.x#343
Tony133 merged 1 commit into
mainfrom
fix/connect-redis-named-export-types

Conversation

@Tony133

@Tony133 Tony133 commented Jul 12, 2026

Copy link
Copy Markdown
Member

Proposal:

Changes:

  • Since v8 ( see v8.0.0 here: https://github.com/tj/connect-redis/releases/tag/v8.0.0), connect-redis no longer has a default export RedisStore is now a named export only. This broke:

    • types/index.tst.ts — type-check failure (tstyche, TS2351: "This expression is not constructable")
    • examples/redis.js and benchmark/bench.js — runtime error, sincerequire('connect-redis').default resolves to undefined

@Tony133 Tony133 changed the title fix: use named import for connect-redis fix: use named import for connect-redis v9.x Jul 12, 2026
@Tony133 Tony133 force-pushed the fix/connect-redis-named-export-types branch from b2c478c to 164e484 Compare July 12, 2026 20:42
@Tony133 Tony133 marked this pull request as ready for review July 12, 2026 20:43
@Tony133 Tony133 requested a review from a team July 12, 2026 20:43
Comment thread package.json Outdated
@Tony133 Tony133 force-pushed the fix/connect-redis-named-export-types branch from 164e484 to 3363308 Compare July 13, 2026 06:47
@Tony133 Tony133 changed the title fix: use named import for connect-redis v9.x fix: use named import for connect-redis v8.x Jul 13, 2026
Comment thread benchmark/bench.js Outdated
@Tony133 Tony133 requested a review from is2ei July 13, 2026 07:43
Comment thread benchmark/bench.js Outdated
@Tony133 Tony133 requested a review from is2ei July 13, 2026 07:54
@Tony133 Tony133 force-pushed the fix/connect-redis-named-export-types branch from 75c3cfb to bf571cb Compare July 13, 2026 07:56
@Tony133 Tony133 requested a review from a team July 13, 2026 08:22
@Tony133 Tony133 force-pushed the fix/connect-redis-named-export-types branch from bf571cb to 9a8c488 Compare July 13, 2026 08:31
@Tony133 Tony133 force-pushed the fix/connect-redis-named-export-types branch from 9a8c488 to 13f87c1 Compare July 13, 2026 08:31
@Tony133 Tony133 merged commit cad6ecf into main Jul 13, 2026
38 of 45 checks passed
@Tony133 Tony133 deleted the fix/connect-redis-named-export-types branch July 13, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants