Skip to content

ci(ci): add node 26 to test matrix#155

Open
Fdawgs wants to merge 2 commits into
mainfrom
ci/ci-26
Open

ci(ci): add node 26 to test matrix#155
Fdawgs wants to merge 2 commits into
mainfrom
ci/ci-26

Conversation

@Fdawgs
Copy link
Copy Markdown
Member

@Fdawgs Fdawgs commented May 18, 2026

Checklist

Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
Copy link
Copy Markdown
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metcoder95
Copy link
Copy Markdown
Member

This is due nodejs/node#62083, and yargs already landed a fix in v18 but c8 still uses v17.

We can chose to wait or just apply an override for c8:

  "overrides": {
    "c8": {
      "yargs": "^18.0.0"
    }
  },

I lean on the latter for it.

@Fdawgs
Copy link
Copy Markdown
Member Author

Fdawgs commented May 26, 2026

We can chose to wait or just apply an override for c8:

Happy to wait tbh rather than having to apply this override to every fastify repo and then removing it once c8 is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants