Skip to content

👷 Update guard-dependencies.yml workflow to allow modifying dependencies for non-fork PRs #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YuriiMotov wants to merge 2 commits into
base: main
Choose a base branch
from
Open

👷 Update guard-dependencies.yml workflow to allow modifying dependencies for non-fork PRs #209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0202bec
Allow modifying dependencies if PR opened from the same repo (not fro…
YuriiMotov May 29, 2026
2adfaf1
Remove redundant logic
YuriiMotov May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .github/workflows/guard-dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,12 @@ jobs:
script: |
const pr = context.payload.pull_request;
const author = pr.user.login;
const assoc = pr.author_association;

const botAllowlist = new Set(['dependabot[bot]']);
const orgAuthorAssociations = new Set(['MEMBER', 'OWNER']);
// Is PR branch in the same repo (not a fork)?
const sameRepo =
pr.head.repo != null && pr.head.repo.id === pr.base.repo.id;

const allowed =
botAllowlist.has(author) ||
(assoc != null && orgAuthorAssociations.has(assoc));

if (!allowed) {
if (!sameRepo) {
await github.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
Expand All @@ -48,5 +44,5 @@ jobs:

core.setFailed('Dependency changes are restricted to organization members.');
} else {
console.log(`Author ${author} (author_association=${assoc}) is allowed to make dependency changes.`);
console.log(`Author ${author} (sameRepo=${sameRepo}) is allowed to make dependency changes.`);
Copy link
Copy Markdown
Contributor

@svlandeg svlandeg Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it makes sense to still refer to author here? Maybe just something like "This PR (...) is allowed ..." ?

}
Loading