Raise error for invalid fields in sqlmodel_update method#1670
Closed
JusticeBrains wants to merge 2 commits intofastapi:mainfrom
Closed
Raise error for invalid fields in sqlmodel_update method#1670JusticeBrains wants to merge 2 commits intofastapi:mainfrom
JusticeBrains wants to merge 2 commits intofastapi:mainfrom
Conversation
Added an AttributeError in SQLModel.sqlmodel_update when attempting to set a field that does not exist on the model. This improves error visibility and prevents silent failures when invalid fields are provided.
Member
|
@JusticeBrains, thanks for your interest! Could you please explain why you think we need this? This is a breaking change and to accept it we need to have strong argumentation. |
Contributor
|
Heads-up: this will be closed in 3 days unless there's new activity. |
Contributor
|
As this PR has been waiting for the original user for a while but seems to be inactive, it's now going to be closed. But if there's anyone interested, feel free to create a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an AttributeError in SQLModel.sqlmodel_update when attempting to set a field that does not exist on the model. This improves error visibility and prevents silent failures when invalid fields are provided.