pin workflow action versions to sha hash, tighten permissions#499
Open
chuckadams wants to merge 6 commits into
Open
pin workflow action versions to sha hash, tighten permissions#499chuckadams wants to merge 6 commits into
chuckadams wants to merge 6 commits into
Conversation
Signed-off-by: Chuck Adams <chaz@chaz.works>
Signed-off-by: Chuck Adams <chaz@chaz.works>
Signed-off-by: Chuck Adams <chaz@chaz.works>
Signed-off-by: Chuck Adams <chaz@chaz.works>
Signed-off-by: Chuck Adams <chaz@chaz.works>
Contributor
Signed-off-by: Chuck Adams <chaz@chaz.works>
chuckadams
force-pushed
the
github_action_hero
branch
from
bf136c1 to
21e9741
Compare
joedolson
previously approved these changes
May 18, 2026
Contributor
|
Do we mind merging this in after #493 since they both touch the CI yaml files (to reduce conflicts). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this should even be in the release branch, given the nature of it, but I'll let someone else decide that. At any rate, they can't be tested until they land in
main.Rationale here: https://github.com/orgs/fairpm/discussions/226#discussioncomment-16965503
if:clauses, since they're regarded as syntax errors, though in these cases GH does DWIM them anyway so the change is just cosmetic.Several actions did get version upgrades as part of the pinning, but I don't think any of our actions are actually backward-incompatible.