Rearchitect Updater into a registry#428
Conversation
…ction` filter (fairpm#401) Signed-off-by: John Blackbourn <john@johnblackbourn.com> Signed-off-by: Andy Fragen <andy@thefragens.com> Co-authored-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: John Blackbourn <john@johnblackbourn.com>
Signed-off-by: Carrie Dils <carriedils@gmail.com> Signed-off-by: Norcross <andrew.norcross@gmail.com> Co-authored-by: Carrie Dils <cdils@users.noreply.github.com>
Signed-off-by: Carrie Dils <carriedils@gmail.com> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Carrie Dils <cdils@users.noreply.github.com> Co-authored-by: rmccue <21655+rmccue@users.noreply.github.com>
23e7bdf to
25bf09e
Compare
|
@johnbillion how do I setup QM to see the hooks you are seeing? |
…ugin- and theme-specific logic as necessary. Signed-off-by: John Blackbourn <john@johnblackbourn.com> # Conflicts: # inc/updater/class-updater.php
25bf09e to
fae1d13
Compare
|
@afragen Can you change the target branch of this PR to |
|
@afragen @chuckadams I forced DCO to pass for your commits. Please remember to sign off :) |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cdils <3099408+cdils@users.noreply.github.com>
) Signed-off-by: John Blackbourn <john@johnblackbourn.com> Signed-off-by: Andy Fragen <andy@thefragens.com> Signed-off-by: Carrie Dils <carriedils@gmail.com> Signed-off-by: Norcross <andrew.norcross@gmail.com> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: joedolson <joedolson@users.noreply.github.com> Signed-off-by: Joe Dolson <design@joedolson.com> Signed-off-by: Shadi Sharaf <shady@sharaf.me> Co-authored-by: Chuck Adams <chaz@chaz.works> Co-authored-by: John Blackbourn <john@johnblackbourn.com> Co-authored-by: Andy Fragen <andy@thefragens.com> Co-authored-by: Norcross <andrew.norcross@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: rmccue <21655+rmccue@users.noreply.github.com> Co-authored-by: joedolson <joedolson@users.noreply.github.com> Co-authored-by: Joe Dolson <design@joedolson.com> Co-authored-by: Shady Sharaf <shady@sharaf.me> Co-authored-by: cdils <3099408+cdils@users.noreply.github.com>
|
@cdils any reason this was closed? |
|
@afragen This should not have been closed. Looks like there's an auto-deletion on the |
|
This PR has also been moved into the "Done" column in the three projects. And it's been moved into the 1.4.0 milestone. I don't have permission to update either of those and I can't reopen the PR, so I'll just create a new one. |
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: John Blackbourn <john@johnblackbourn.com>
… undefined. Signed-off-by: John Blackbourn <john@johnblackbourn.com>
Fixes #427
I've been using this on my local installation for a couple of weeks, although with a fairly limited number of updates. Needs some thorough testing by the FAIR Connect team.
Testing
See my comments on #427 about installing the add-on plugin for Query Monitor to see the duplicate hooks.
Testing this requires installing more than one plugin or theme that has a
Plugin ID: did:plc:...header. You can install Pods, Query Monitor, User Switching, and WP Crontrol for testing this. They don't need to be active.Prior to testing you can choose to flush all your transients or not. This change doesn't affect the way transients for updates are stored or handled so it will continue to work with your existing cache.
In order to trigger and test an update check for a plugin or theme, you'll need to clear the appropriate transients.
Items to test:
Before
After