Skip to content

Rearchitect Updater into a registry#428

Merged
afragen merged 15 commits intofairpm:release_1.4.0from
johnbillion:instances
Feb 12, 2026
Merged

Rearchitect Updater into a registry#428
afragen merged 15 commits intofairpm:release_1.4.0from
johnbillion:instances

Conversation

@johnbillion
Copy link
Contributor

@johnbillion johnbillion commented Jan 29, 2026

Fixes #427

I've been using this on my local installation for a couple of weeks, although with a fairly limited number of updates. Needs some thorough testing by the FAIR Connect team.

Testing

See my comments on #427 about installing the add-on plugin for Query Monitor to see the duplicate hooks.

Testing this requires installing more than one plugin or theme that has a Plugin ID: did:plc:... header. You can install Pods, Query Monitor, User Switching, and WP Crontrol for testing this. They don't need to be active.

Prior to testing you can choose to flush all your transients or not. This change doesn't affect the way transients for updates are stored or handled so it will continue to work with your existing cache.

In order to trigger and test an update check for a plugin or theme, you'll need to clear the appropriate transients.

Items to test:

  • Update checks
  • Update notices
  • Performing updates

Before

After

chuckadams and others added 6 commits January 2, 2026 17:27
…ction` filter (fairpm#401)

Signed-off-by: John Blackbourn <john@johnblackbourn.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
Co-authored-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: John Blackbourn <john@johnblackbourn.com>
Signed-off-by: Carrie Dils <carriedils@gmail.com>
Signed-off-by: Norcross <andrew.norcross@gmail.com>
Co-authored-by: Carrie Dils <cdils@users.noreply.github.com>
Signed-off-by: Carrie Dils <carriedils@gmail.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Carrie Dils <cdils@users.noreply.github.com>
Co-authored-by: rmccue <21655+rmccue@users.noreply.github.com>
@github-actions
Copy link
Contributor

@johnbillion johnbillion marked this pull request as ready for review January 29, 2026 16:28
@afragen afragen requested review from afragen, costdev and rmccue January 29, 2026 17:03
@afragen afragen added this to the 1.4.0 milestone Jan 29, 2026
@afragen afragen added enhancement New feature or request needs review Probably ready for work, but needs eyes to double check. labels Jan 29, 2026
@afragen
Copy link
Contributor

afragen commented Jan 29, 2026

@johnbillion how do I setup QM to see the hooks you are seeing?

…ugin- and theme-specific logic as necessary.

Signed-off-by: John Blackbourn <john@johnblackbourn.com>

# Conflicts:
#	inc/updater/class-updater.php
@johnbillion
Copy link
Contributor Author

@afragen Can you change the target branch of this PR to release_1.3.0 please? I don't know why I don't have permission to do it.

@afragen afragen changed the base branch from main to release_1.3.0 February 3, 2026 23:14
@Ipstenu
Copy link
Contributor

Ipstenu commented Feb 9, 2026

@afragen @chuckadams I forced DCO to pass for your commits. Please remember to sign off :)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: cdils <3099408+cdils@users.noreply.github.com>
)

Signed-off-by: John Blackbourn <john@johnblackbourn.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Carrie Dils <carriedils@gmail.com>
Signed-off-by: Norcross <andrew.norcross@gmail.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: joedolson <joedolson@users.noreply.github.com>
Signed-off-by: Joe Dolson <design@joedolson.com>
Signed-off-by: Shadi Sharaf <shady@sharaf.me>
Co-authored-by: Chuck Adams <chaz@chaz.works>
Co-authored-by: John Blackbourn <john@johnblackbourn.com>
Co-authored-by: Andy Fragen <andy@thefragens.com>
Co-authored-by: Norcross <andrew.norcross@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: rmccue <21655+rmccue@users.noreply.github.com>
Co-authored-by: joedolson <joedolson@users.noreply.github.com>
Co-authored-by: Joe Dolson <design@joedolson.com>
Co-authored-by: Shady Sharaf <shady@sharaf.me>
Co-authored-by: cdils <3099408+cdils@users.noreply.github.com>
@cdils cdils deleted the branch fairpm:release_1.4.0 February 10, 2026 20:28
@cdils cdils closed this Feb 10, 2026
@afragen
Copy link
Contributor

afragen commented Feb 10, 2026

@cdils any reason this was closed?

@cdils
Copy link
Contributor

cdils commented Feb 10, 2026

@afragen This should not have been closed. Looks like there's an auto-deletion on the release_1.3.0 branch after the merge and that triggered closing open PRs against that branch. Clearly some kinks to work out. I'll flag this in Slack.

@johnbillion
Copy link
Contributor Author

This PR has also been moved into the "Done" column in the three projects. And it's been moved into the 1.4.0 milestone. I don't have permission to update either of those and I can't reopen the PR, so I'll just create a new one.

Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: Andy Fragen <andy@thefragens.com>
@afragen afragen reopened this Feb 12, 2026
afragen and others added 3 commits February 11, 2026 18:05
Signed-off-by: Andy Fragen <andy@thefragens.com>
Signed-off-by: John Blackbourn <john@johnblackbourn.com>
… undefined.

Signed-off-by: John Blackbourn <john@johnblackbourn.com>
Copy link
Contributor

@afragen afragen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@Ipstenu Ipstenu changed the base branch from release_1.3.0 to release_1.4.0 February 12, 2026 17:19
@afragen afragen merged commit e9dd5d2 into fairpm:release_1.4.0 Feb 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs review Probably ready for work, but needs eyes to double check.

Projects

Archived in project
Status: Done

Development

Successfully merging this pull request may close these issues.

🐞 Bug Report: Every FAIR-enabled plugin or theme results in a new Updater instance adding its hooks

6 participants